Jakub Zelenka

Results 96 comments of Jakub Zelenka

Just basic `crypto.file://` stream and checking context params is implemented at the moment

@echoline I have added few comments as I saw some recent commits. Is this PR still active? If so it would be also good to add a test for this.

I think it's more that the contributors don't have much time. I think Steffen (the creator) hasn't been active for some time and Anders said that he won't longer have...

Yeah more or less like you say. I can't really promise reviewing bigger pieces as it all depends if I have some time which might take a bit. But small...

I think it makes sense in general to have some way how to identify error on ann when train data cannot be created. There is an error in error log...

@troiganto Nice review! I agree that the docs should be updated and c++ headers added. I think it would be also good to have some tests (googletest) or at least...

I would suggest to use `fann_error` and possibly create a new error type for that purpose so it's more consistent and also the message is set.

Hi, I just tested the snippet with the uploaded file on Linux and it loads the network correctly without any crash. It looks that it is a platform specific though....

I managed to re-create the bug when I tested completely invalid conf file (the uploaded file is correct on linux so I tested completely invalid input: https://github.com/bukka/php-fann/blob/master/tests/fann_create_from_file_basic.phpt#L17 I added the...