Corey Hickey

Results 52 comments of Corey Hickey

@tytso is this PR acceptable? Please let me know if there is a procedure I need to follow; I wasn't able to find any guidelines beyond the `SUBMITTING-PATCHES` file in...

To address: https://github.com/jordansissel/fpm/pull/1806#issuecomment-964778985 As to why I used JSON: it's been a while since I wrote that patch, but I think my thought process was basically: 1. Something like `--map...

One other way that JSON works well is when needing to support a mapping that is not static across different OS/python version combinations. Once this gets complex enough, then using...

Updated PR contents to: * fix use with modules which run `setup()` under a check for `__main__` * fix use with modules which specify `distclass` as well Updated PR description...

Updated PR contents to fix inconsistency in package names vs. dependency names. This fixes a pre-existing bug (not a bug I introduced).

Fixed some typos in my commit message.

Updated PR contents to: * compile `setup.py` contents before` exec()` in order to be able to have better line numbers * set `__file__` for the `exec()` environment in order to...

Updated PR contents to: * change default behavior to allow packages with underscores * support name remapping

Yes please, go ahead. Sorry for the churn earlier. I was in the midst of a project and kept finding edge cases, and I'm done with that now. All the...

Thanks for the feedback. I can work on addressing it in between some other work. If I don't address some parts for a while, I probably have not forgotten--I just...