Tom Haile comments

Results 54 comments of


                                            Tom Haile

[Feature Request] Allow pre-filling of order quantity to close entire position

User just wants to pre populate the form by clicking on a value in their position. I can see that this could be difficult because of synthetic positions. I think...

[Feature Request] Allow pre-filling of order quantity to close entire position

I like that format to allow the user to put a percentage of total ETH toward a trade. It would be easier now that we all user to input total...

[Feature Request] Allow pre-filling of order quantity to close entire position

I agree with both, especially if we have 0x “fast” trading

[Feature Request] Allow pre-filling of order quantity to close entire position

moving this out of sprint, sprint is for blocking features, high pri items

Back button in UI doesn't always go back to correct page

It will be less obvious in the redesign. This is an issue of how we handle navigation history and our back buttons. We do a makeshift version of “back” with...

Back button in UI doesn't always go back to correct page

moving to `design review` for testing

Create test suite for template generator.

There is a flash script `validate-template` that is used to manually validate market creation template object. There are examples in flash README.md how to use it. The "production" templates are...

Create test suite for template generator.

I agree with a test that runs market created template variations against validate-template flash script. I think that would be useful.

All code paths that deal with user input should be protected against exceptions.

Nice one, there is a try catch that starts on line 336. Will include the above lines in the try catch.

Update flow-js-testing handlebars templates to @[email protected]

closing, will need to reevaluate after polish sprint and mvp testing