sushmith

@StewartJingga Can you link the corresponding issue with details to this PR. Also, would this change break the recipe contracts by any chance? If, from a usage perspective, there is...

I think in addition to the above and detailed documentation, we should have also a command/api similar to `guardian policy validate` or `guardian policy lint` so that one can run...

Created issue https://github.com/odpf/guardian/issues/237

Currently, the way the config is read and parsed is thru viper, and viper uses `mapstructure` tags and if those are not present, it uses the var names(lowercase) in the...

This change will make the internal grpc logs messages in the general format as the shield server msgs. Before: ``` {"level":"info","msg":"finished unary call with code OK","grpc.start_time":"2022-03-02T12:52:43+05:30","system":"grpc","span.kind":"server","grpc.service":"odpf.shield.v1beta1.ShieldService","grpc.method":"ListRoles","grpc.code":"OK","grpc.time_ms":33.39400100708008} ``` After: ``` 2022-03-02T12:49:49.474+0530...

Things to consider: * The internal grpc logging msg (`finished unary call with code OK {...}`) is thrown by the intercepter internally that we add to the server. We need...

This PR is no longer needed. The corresponding changes were added and merged through the #164 - https://github.com/odpf/shield/pull/164/files#diff-d0706a4ae4ecf91c5224ca388f31a087a36af06c40dc81321da7958b25c70b23

@singhvikash11 these changes are present in the latest version of salt. Can we bump up the salt version and use that?

@singhvikash11 Can you add a github issue with all the specific details?

@Chief-Rishab This is an interesting feature. 👍 Assuming that the new type - `team/group` will be created in guardian in addition to `user` & `serviceAccount`. I have a couple of...