Byoungro So
Byoungro So
It looks great assuming that before_platform_add and after_platform_add hooks could be platform specific. My understanding about the current convention is a little different, though. Thanks, Tony.
@intel/llvm-reviewers-runtime @gmlueck @bader Here is the initial PR that I presented in the DPCPP technical forum. The intention of this PR is to get some early feedback from you. Please...
> Moving the discussion on #12393 to here: > > We (the kernel fusion team) could re-use a `std::string` replacement class in our [effort ](https://github.com/intel/llvm/pulls?q=is%3Apr+%5BNoSTL%5D) to remove STL classes from...
@jopperm I refactored this PR to have two separate classes sycl::detail::string and sycl::detail::string_view.
I would like to make some general comments here to the reviewers. I appreciate your feedback, but I got the impression that the reviewers think sycl::detail::string is just a replacement...
Thanks, @victor-eds and @aelovikov-intel I think I addressed all your feedback. Some of them cannot be satisfied due to the restriction of the dual ABI usage case. If I missed...
@aelovikov-intel @victor-eds Thank you for your additional feedback. I think I addressed all your feedback. Please let me know if I missed anything.
@jopperm I think I addressed all your feedback.
> @aelovikov-intel changes would be good. `string` needs the special member functions being overriden, but not needed for `string_view` @victor-eds , could you elaborate on what changes you are requesting?