Ben Scott comments

Results 68 comments of


                                            Ben Scott

GitHub-16568: Reordering fields to match the expected order

LGTM!

[BZ2106760] backport 4.9 Change delete-local-data to delete-emptydir-data

LGTM.

[enterprise-4.10] Issue in file installing/installing_vsphere/installing-vsphere.adoc

/assign bscott-rh

[enterprise-4.11] Issue in file installing/installing_aws/installing-aws-network-customizations.adoc

/assign bscott-rh

RNs-4.7.56: adds zstream update

LGTM.

Removes TP baner

LGTM.

[BZ2106760] backport 4.8 Change delete-local-data to delete-emptydir-data

LGTM.

OSDOCS-3940 Enabling GCP Shared VPC IPI installation

@jianli-wei Hello Jianli, PTAL at this documentation for GCP IPI installation on shared VPC. Thank you

OSDOCS-3940 Enabling GCP Shared VPC IPI installation

> @bscott-rh "Table 4. Additional GCP parameters" doesn't list the new parameters introduced by this epic, better to add them. Thanks! I am intending to create a separate PR to...

OSDOCS-3940 Enabling GCP Shared VPC IPI installation

> > Could you let me know if the rest of the content in this PR looks good? > > @bscott-rh Please see my 3 comments above, thanks! Which 3...