Brox Chen
Brox Chen
With annotated_ptr  Without annotated_ptr 
Hi @steffenlarsen @Pennycook Please let me know your thoughts on this PR. Thanks!
Sync with Joe and IVan offline, since the sorting might not work for dasm very well. For now, we just sort the "_t16_err.s" and "_t16_prmote.s" files and keep other files...
> LGTM, but please remove double empty lines in err/promote files. done!
> Could you add a test for sorting with an input that contains some comments. > > Ideally those comments would remaing attached to the line they were on before....
Adding more reviewers to seek a wider consensus on sorting MC tests throughout
> Adding more reviewers to seek a wider consensus on sorting MC tests throughout Discussed offline with Joe and Ivan. The dasm sorting might not be very useful right now...
I think the op_sel testline might be missing for these instructions. I guess the op_sel testlines in the downstream is not complete? @Sisyph can you help to confirm? Thanks!
Updated GFX11 asm test with op_sel testlines. Now ready for review!