Brijesh Bittu comments

Results 141 comments of


                                            Brijesh Bittu

Type Annotations?

Will be possible for top level exports but I don't think it will be possible for the actual vim wrapper itself.

Type Annotations?

It'd be better to have in this repo itself to avoid installing extra package.

'shiftCommand.js not found' + 'Duplicate definition of module shiftCommand'

Seems like you are using AMD / requirejs type loader. Did you follow the amd instructions in the readme. Or could you paste the code snippet of how you are...

Only import the editor API instead of the whole package so that Webpack only loads relevant code

This is something that you can control using webpack resolver or babel where monaco-editor can be aliased to the api file.

Only import the editor API instead of the whole package so that Webpack only loads relevant code

You'll also need to update the webpack config so that the umd build works as well.

Only import the editor API instead of the whole package so that Webpack only loads relevant code

AMD version should be what it is currently. It doesn't have api file.

Option to avoid focus on editor when dipose

As a pointer, this is the culprint line - https://github.com/brijeshb42/monaco-vim/blob/master/src/statusbar.js#L94

Monaco commands with overlapping shortcuts get ignored

> I think Monaco utilizes commands to handle keybindings. Not sure if it's being used here, but that might be beneficial for chaining events like this. My initial implementation tried...

Up/Down in command mode doesn't show history of previous commands

This is out of scope with the way current functionality is implemented.

Global substitute command hangs when replacement string contains search string

Tried this on the playground and it worked fine for me. Editor does not hang. Could you provide a reproducible url on maybe codesandbox.