Brian Johnson
Brian Johnson
not sure I understand. ipcRenderer.send works, but not webContents.send? That seems very odd because the same converters will apply in both directions. Where are you trying to send from?
ipcMain.send doesn't go anywhere. What are you trying to send to?
so for instance we might have something like `https://brave.sync.com/v1`, `https://brave.syn.com/v2` and whatever corresponding identifier we would need for different lambda deployments. That way we can coordinate the client changes with...
after speaking to @rebron we should add a checkbox if you want to keep it in the dock (unchecked by default)
same dialog ^^
I'm not seeing tests that are clearly labelled as testing the items from the issues except for "Don't remove thumbnail file". The issues themselves also lack details for QA testing...
In the meantime what about a `rust::Result` cpp class for `RUST_CXX_NO_EXCEPTIONS`? That leaves the handling of `rust::Result` to the caller and it could be converted to some other type (like...
why is this assigned to me?
Several suggested reviewers were missing from the list. Please be sure to always add all suggested reviewers and double-check after changing any new files
> I'm curious why the our own first run dialog is removed. It seems to have some our own options like pin to task bar. cc @simonhong for first run...