Brian May

Results 490 comments of Brian May

I filled a bug report about this against Django. https://code.djangoproject.com/ticket/24768 - it was somewhat confusing because the reverse accessor produced results of the wrong type, and I didn't realize at...

@richardjmarini There is the following code in the `copy_fields` method: ``` python if field.rel and field.rel.related_name: field.rel.related_name = '_auditlog_%s' % field.rel.related_name ``` My tests sure that normally this doesn't get...

This change seems to have broken Django 1.7 support :-( ``` Traceback (most recent call last): File "./manage.py", line 24, in management.execute_from_command_line() File "/usr/lib/python2.7/dist-packages/django/core/management/__init__.py", line 385, in execute_from_command_line utility.execute() File...

Of course, you could argue that Django 1.7 support was already broken... None of these related_name values were getting set. It seems under Django 1.7 the defaults were sane values...

@wkang0 No, that still won't work (as desired) under Django 1.7, for exactly the same reasons that the original code didn't work properly under Django 1.7 (it didn't crash, but...

Oddly enough, e6781837267773bba25338fe33f9198e235bf26b changes the behaviour so that an error is generated instead: ``` karaage.PersonAuditLogEntry.action_user: (fields.E300) Field defines a relation with model 'karaage.Person', which is either not installed, or is...

Defining a forward reference from `PersonAuditLogEntry` to `Person` here is not as easy you might imagine, for reasons I don't really understand. - `Karage.Person` does not work. - `apps.get_app_config('karaage').get_model("Person")` does...

Just for the record, I believe that #16 was applied, just not exactly the same way as in the merge request. @tysonclugg Was going based on what happens for all...

I believe #16 was closed by 529327db618d63dccbce6f682cb27ec99c6997af

It seems to be that under certain circumstances the code introduced by #16 doesn't get `AUTH_USER_MODEL` value correctly (it gets the default value instead), and as a result, the condition...