Brian Love

Results 14 issues of Brian Love

I'm trying to have a model with a 'created_by' column that joins to the 'id' column of a user model. Since the name of the column is not of the...

Provide a clearer, up-front explanation of the three cases for the `dependencies` parameter in `useEffect` to reduce the need to click through to the more in-depth explanation further down. I...

CLA Signed

I'm trying to add a Trellis-based graph within a Nuxt/Vue website. When I try using the most recent `0.6.1` release I get the error described in #81 (this also happens...

Dark text on a blue background is not easily readable, especially at a distance. The dark text should instead be a lighter color, like white or `--bright-blue-lightest`. ![image](https://github.com/georgetown-cset/eto-chip-explorer/assets/22353962/0c86ad52-1a63-4101-a70b-28af42bc6887)

bug
accessibility

`react-loadable` is no longer being updated and uses deprecated React functions. Replace it with `Suspense`/`lazy` (see https://github.com/georgetown-cset/science_map_ui/pull/580). ``` console.warn Warning: componentWillMount has been renamed, and is not recommended for use....

tech debt

Set up Percy visual snapshot testing Closes #622

Both the [Packaging Tools](https://chipexplorer.eto.tech/?parentNode=N69&selectedNode=N76) and [Integrated Assembly Tools](https://chipexplorer.eto.tech/?parentNode=N69&selectedNode=N77) charts seem too narrow compared to the other charts ![Image](https://github.com/user-attachments/assets/60ba2ca1-fac9-4041-9a26-8b79d62a6f88)

bug

Various bits of refactoring should be done concurrent with the data update. Add visual testing with Percy to provide additional checks that the refactoring doesn't mess things up.

testing

Running the `__tests__/dashboard.js` tests gives the following error message: ``` console.error Warning: Encountered two children with the same key, `[]`. Keys should be unique so that components maintain their identity...

tech debt
testing