Dean Brettle

The crashes also seem to be associated with seeing the warning from this line: https://github.com/wpilibsuite/allwpilib/blob/3d6b710293d1e78f2d43834068cf610f53440f0f/ntcore/src/main/native/cpp/net/ServerImpl.cpp#L212 I'm assuming that is occurring because the unpublish is delayed getting to the server (due...

Test case that produces warnings can be found [here](https://github.com/DeepBlueRobotics/DeepBlueSim/blob/62010c9a301061d04d8956d3c24d940781d1cfe0/example/src/test/java/frc/robot/NetworkTablesLoadTest.java).

I have a theory about the cause of this bug and would like to know if I'm barking up the wrong tree. In `ClientImpl::HandleLocal()`: https://github.com/wpilibsuite/allwpilib/blob/e2893fc1a36720b9c3986f2fc6c9607cea35c8fd/ntcore/src/main/native/cpp/net/ClientImpl.cpp#L121-L122 `Unpublish()` calls: https://github.com/wpilibsuite/allwpilib/blob/e2893fc1a36720b9c3986f2fc6c9607cea35c8fd/ntcore/src/main/native/cpp/net/ClientImpl.cpp#L220 which "erases"...

Is this considered a bug or was it considered a necessary part of #5659?

Ok to just ifdef the existing `flush()` or do you want a separate `flushNow()`?

Actually, I'd need it not just for servers, but clients as well. Is there an acceptable/recommended way that the client could determine that it is talking to a non-RIO server?

> I wouldn't want something like this, as I run a very different settings.json. Can your user-specific settings be put in your user settings instead of the folder settings? If...

I could live without the format-on-save being in the folder settings. I could move that to my user settings. I am primarily interested in getting the wpilib specific style in...

> One of the biggest things I worry about is when you're working on the C++ side, a lot of random file associations get added, in the `files.associations` key. So...

> One other concern is that I don't think this will fully cover all the formatting that CI enforces. I find I trigger spotless a lot more often then wpiformat....