Brett Burley

Results 9 comments of Brett Burley

I've been playing around with `ember-intl` with `ember-engines` a bit to see what the current behavior is. @buschtoens does your engine itself list `ember-intl` as one of its dependencies in...

> One blocker I see currently is that setProperties is called with a new object each time (w/ Object.assign) likely resulting in a notifyPropertyChange for each property in the component....

I don't think `Object.assign` will change the behavior at all. Let's see after #42 is updated if the counts still mismatch... I would expect them to be the same in...

This looks great! Thanks for all the work @dustinfarris.

@toranb I don't think it's a _breaking_ change since there aren't any meaningful apps with a missing `reducers/index.js` file. I don't think this PR changes the API in any way...

I probably missed some prior discussion on this, but is this functionally equivalent to the syntax you'd use today? E.g. ``` import Ember from 'ember'; import route from 'ember-redux/route'; function...

Yep, this still looks good to me!

@LucasHillDex have you seen https://github.com/villander/ember-engines-router-service? This addon preserves the encapsulation you're looking for when routing via service within an engine.

Ha! I was considering introducing the `clearRender()` call to the [`setupRenderingTest` helper in `ember-qunit`](https://github.com/emberjs/ember-qunit/blob/main/addon/src/index.js#L63) as an afterEach hook. However, it seems to trigger failures in many of our test suites...