Earl Sampson
Earl Sampson
I see two failed tests: Automatus CS8 / Run Tests (pull_request) Failing after 8m — Run Tests Automatus CS9 / Run Tests (pull_request) Failing after 6m — Run Tests Error...
@jan-cerny thanks and fixed. I saw the exit 1 at the end of the details for two two tests and that it was a from the remediation run log. I...
Still seeing the Script home_dirs_with_same_groupowner.fail.sh failure, but I have renamed that to home_dirs_with_same_groupowner.pass.sh, is that change not getting picked up?
Thank, Now show as rename without change. I used "git mv" to rename the file. Not sure what happened. File was removed from my local branch, but the push made...
@jan-cerny Thank you, finally looks clean.
@yuumasato @lonicerae It is very clever bit a shell coding, and yes I think it would handle the cases. I don't really understand what this addresses that is not handled...
Not an issue for this review, but couple flavors of the following are supported. ``` include( file=`echo $ENV_VAR` mode="optional" ) '''' Which I don't find amusing. And should have check...
I think that the find should stay. Mode optional in following means that the no error generated if file not present. ``` include( file="/path/to/include.conf" mode="optional" ) ``` So, trying to...
@lonicerae I had looked over your initial PR. You and I were working on the same issue from different angles and came up with what I think are relatively equivalent...
changing the find loop to: ``` RSYSLOG_FILES=() for ENTRY in "${RSYSLOG_CONFIGS[@]}" do echo "$(dirname "${ENTRY}")" " " "$(basename "${ENTRY}")" if [[ -d "${ENTRY}" ]]; then mapfile -t FINDOUT <