Brent Clark

Results 8 comments of Brent Clark

I think this is a good idea. What would this look like on the operations side of things? As in, where do these submissions go? Do they hook up into...

I like the idea of adding that link, since I think this is the right spot to make sure everyone is on the same page about what's expected by all...

@moshfeu I'll grab this.

Oh whoops, the builds are failing because they are expecting a `package-lock.json` file to be in this PR as well. Can you add that @skybloo?

How do you feel about splitting these up into separate issues so they can be worked on separately?

@crysfel, how do you feel about *only* using the `slug` instead of maintaining both the `slug` *and* the `_id`?

ohhh, right. Great point. Then my idea is bad for the short term. How do you feel about moving to a "slug only" approach *eventually*? As in, after the FE...

I commented out the file at `tests/mtgjson5/providers/test_cardmarket.py` as it was complaining about the availability of `mocker`. I'm happy to fix it in this PR if anyone can provide some direction.