Brennen Puth comments

Results 7 comments of


                                            Brennen Puth

AprilTag ID to Pose API

The last things that need done before marking this PR truly ready for review I believe is creating tests for pose mirroring and possibly other serialization tests to ensure parity...

Refactor inbuilt AprilTagFieldLayout loading process

Changing the layout definitely needs to be a conscious decision. Running your bot on a Charged Up field just to have it think it's in the wrong place because the...

Refactor inbuilt AprilTagFieldLayout loading process

Unsure how to go about this for C++, as I am unfamiliar with the code generation that's happening there. Can the methods from AprilTagFields just be moved to AprilTagFieldLayout and...

Allows multiple bibleVersion

I would like to expand on this idea and bring it back to life. I do not think setting up a automatic "two-translation" version is that helpful, but it would...

error: nvim_echo must not be called in a lua loop callback

Just attempted the fix/echo-loop branch, chiming in to say that the fix works perfectly for me.

Silent failure if framed.sty is not found

I've done a little more research, and it looks like the output is being reported (it shows up when running `:messages`) but it doesn't show up in the bottom bar...

refactor: updated to `vim.lsp` as `require("lspconfig")` is deprecated

Bumping this PR - I've been having this annoying warning on my NeoVim config for a while now, and I was only just able to track it down to this...