Brendan Maginnis

Results 40 comments of Brendan Maginnis

I actually think the original version was better where it didn't jump between windows with j/k. Any chance we could get that?

Thanks for the report @diceroll123 We don't yet analyse classes, which means that we don't know that `Dummy(test=True)` sets the property `m.test`. On the other hand we assume that setting...

Sourcery is accidentally deleting the comment, hence it's highlighting that line as it's the first to change

Hi @Alex-CodeLab, I've run this locally and I get the following suggestion which looks correct: Please can you check you're using the latest version of Sourcery in PyCharm by going...

My mistake, I wasn't trying this in PyCharm. I have now successfully reproduced this and have a fix for the next release

Thanks for reporting this @bwagner. I have reproduced and have a fix for the next release

Thanks for reporting this @Lin-Your. We've seen this on Linux too. We're looking into it

This is a great idea @willfrey! We'll look into it

PRs should have comments for each refactoring, I introduced a bug today which stopped them appearing for a while but that has now been resolved. Your idea for using GitHub...

Sourcery refactors at the function level at the moment but at some point it will be extended to refactor at the class and module level. It would be fairly easy...