Bricked
Bricked
Edited the PR to contain fewer changes. Additional configs and options for other browsers are probably not scope of this PR and can be added once this is merged.
Derived branches [Librewolf](https://github.com/brckd/home-manager/tree/ff-forks/librewolf) and [Floorp](https://github.com/brckd/home-manager/tree/ff-forks/floorp) seem to work. Will add tests for derivatives soon.
It would probably more elegant to keep the old module, move it to `modules/programs/firefox/mkFirefoxModule.nix` (or perhaps `modules/lib/firefox`?) and wrap it into a method that accepts config parameters. Then just import...
Created the mkFirefoxModule method and added generic tests. This means the PR ticks all boxes and is ready for review! :tada:
Here are some things that could still be worked on: - instead of passing configs to `mkFirefoxModule`, make them `internal` options - move generic module factories to `modules/lib` What do...
A maintainer needs to review it.
Thanks for the review! My NixOS installation is currently broken, so it'a difficult for me to test the suggested changes, but I will make sure to try them soon.
+1 this is exactly what i was looking for! however, my school summarizes multiple courses with the same subject as one class, so i can't hide these redundant courses. therefore,...
Sorry, my bad. That happened when i changed the objective of the prior PR.
Uh yea so I had like a personality crisis but I might reinstall NixOS next week and see how far I get. Sorry for letting you wait.