Brandon Culver

Results 8 comments of Brandon Culver

Confusing docs around path rewrite

I agree. It would potentially be a breaking change for people already using it. Personally, I just removed the return false locally and it works as I expected in my...

Confusing docs around path rewrite

I really can't unfortunately do to some internal agreements. The pseudo code I posted is accurate though. client calls `/original/api/call?queryParam=abc&token=123` but token may or may not be the first,second,third, etc...

Data source, SMA calculation and Y outputs offsets

``` function ComputeSMA(data, window_size) { let r_avgs = [], avg_prev = 0; for (let i = 0; i

Cache is global, can potentially conflict with external modules

I think this is a matter of personal opinion. There are other node caches that do this, but then they suffer from not following typical require patterns (requiring in multiple...

Cache is global, can potentially conflict with external modules

@olalonde I understand what you are saying. I mean namspacing your cache keys. ('myapp-cache1', myapp-cach2) I would also question why you are using this particular module in other libraries. Its...

Support for encoding option in fs.readFile and fs.readFileSync

:+1:

[BUG] hardcoded version of `worker-build` in starter template causing issues with preinstalled versions of wasm-pac

This happened to me as well, thanks for explaining the issue. Solved by uninstalling global wasm-pack

Concerns about the way node-oracle handles cursors in results from stored procs

This would be ideal, would like to interact with a table that has 4.5 million rows.