Lidong Yan

I prefer the former implementation due to its uniform using of inode. Why change now? Is there any special reason?

At line 56 in [fn new] lib.rs, variable contents, whose type is a String, call to_string on itself. Why to_string is needed here. (I remove it, the code still work...

ClangBitcodeArgumentListFilter use its local callback `outputFileCallback` which does exactly the same thing ArgumentListFilter does. ClangBitcodeArgumentListFilter's `outputFileCallback` ``` def outputFileCallback(self, flag, filename): self.outputFilename = filename ``` ArgumentListFilter's `outputFileCallback` ``` def outputFileCallback(self,...

pack-bitmap: fix memory leak if `load_bitmap` failed

59

This patch prevents pack-bitmap.c:load_bitmap() from nulling bitmap_git->bitmap when loading failed thus eliminates memory leak. This patch also add a test case in t5310 which use clang leak sanitizer to detect...

revision: fix memory leak in prepare_show_merge()

27

In revision.c:prepare_show_merge(), we allocated an array in prune but forget to free it. Since parse_pathspec is not responsible to free prune, we should add `free(prune)` in the end of prepare_show_merge()....

REFTABLE_REALLOC_ARRAY: fix potential memory leak if realloc failed

15

REFTABLE_REALLOC_ARRAY doesn't free origin pointer when reftable_realloc failed. This leak can be fixed by add a free(x) before set x to NULL. cc: René Scharfe cc: Patrick Steinhardt

fix xstrdup leak in parse_short_opt

37

Pass a user defined strdup-like function in parse_opt_ctx to avoid memory leak. cc: Patrick Steinhardt cc: Phillip Wood