Brady Madden

Results 18 comments of Brady Madden

Moved gif tool to Go. Need a better palette than standard plan9/ webpack that matches image color better and produces more accurate gif.

GIF failing on larger images

That makes sense, but is there a reason VSCode behaves differently? The CM plugin API doesn't seem to allow us to see _potential_ expansions and perform further filtering to only...

WIP in this branch https://github.com/replit/codemirror-minimap/compare/line-wrapping?expand=1

Yeah it can get very unperformant for large documents. It's a large refactor that I haven't had time to do yet. Out of curiosity, how large was your document where...

Wait, the link I sent above is from `typescript-language-features`, not vscode core: https://github.com/microsoft/vscode/blob/fd4b93963e6456d09175410ea1cc84cb796ad241/extensions/typescript-language-features/src/languageFeatures/quickFix.ts#L330 That's exactly why I thought this should be a typescript-language-server responsibility. If generic clients adjust their range...

EDIT: I see where sublime adjusts the range now. However, I'm still curious about your thoughts on the vscode behavior. https://github.com/sublimelsp/LSP/blob/d4538fa34ff689672ec60ab8f585b3cb4c828f49/plugin/documents.py#L278 ~Fwiw, I don't see Sublime doing this in their...

I'm a bit confused. I've read those parts of the spec, but I don't know if it explains the inconsistent behavior that occurs when **import1.ts** has been open - and...

It feels like there is some distinction being made for files that have programmatic edits triggered by an `ApplyWorkspaceEdit`, versus any other file that was edited programmatically. Here's an example:...

Interestingly I retried a minimal repro and was unable to repro the error - even when I _didn't_ reopen the closed file before editing it directly on the file system....