Brad Hanks

Results 19 comments of Brad Hanks

I might have a fix for this.

``` iex(1)> Earmark.as_ast " anything that follows the comment is lost " {:ok, [ {:comment, [], [" Replace with better image "], %{comment: true}}, {"p", [], [" anything that follows...

yeah i just submitted it as a placeholder.

> The number of files affected is big. > > Let me revisit this after getting a bit more comfortable with the code. I intend to merge this. yes it...

> > yes it saw that. I wasn't sure if it was bc formatting styles had really changed, or existing suntax was > > unconventional or what > > as...

> > yes it saw that. I wasn't sure if it was bc formatting styles had really changed, or existing suntax was > > unconventional or what > > as...

I removed everything except the one format file

One idea would be to delegate wrap_error/1 to /2 with an empty map and add: %{file: __ENV__.file, fun: __ENV__.function, line: __ENV__.line} as a second argument. Then delegate format_error/1 and format_reason/1...

> Seconding what @whatyouhide said. I think we can add additional context to determine the reason for a closed connection but I don't think adding source location metadata is the...

> A tuple could be seen as a breaking change though, so let's see if we can go with an additional field in the exception first 🙃 open to any...