Braden Watkins

Results 11 comments of Braden Watkins

Looking into it more, it looks like an underlying issue with react-simple-code-editor. https://codesandbox.io/s/boring-fermat-r04c4

@tadelesh, please apply the appropriate suppressions to this PR - `Approved-Avocado` - Avocado triggered because the paths were not included in the new version and it is part of the...

> Do you mind providing a summary on the main changes in this API version? The diff shows many changed files; but it seems some of them are caused by...

> > ``` > > "description": "Country code uses IS02, 2-digit format.", > > ``` > > Typo - `IS0` instead of `ISO`. Probably worth spelling out the full ISO...

> > ``` > > "description": "Amount value.", > > ``` > > It might be worth adding more info in the description regarding whether the value is for the...

> > ``` > > "Resource": { > > ``` > > Can it be replaced by the `Resource` defined in common types? https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v5/types.json > > Refers to: specification/billing/resource-manager/Microsoft.Billing/stable/2024-04-01/types.json:81 in...

> > ``` > > "Error": { > > ``` > > Can it be replaced by the `ErrorDetail` defined in common types? https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v5/types.json > > Refers to: specification/billing/resource-manager/Microsoft.Billing/stable/2024-04-01/types.json:15 in...

> > from: reservation.json > > Have had any discussions with the reviewers already ? This is not really a great practice just suppressing all these errors. Could you please...

> Was this PR actually generated using OpenAPI hub ? I dont see the base version commit to do the diff for the changes here ? ![image](https://private-user-images.githubusercontent.com/11067581/324130625-a8a4e49d-8f97-46e0-98a9-36db3a3e1569.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTM1NjYyOTMsIm5iZiI6MTcxMzU2NTk5MywicGF0aCI6Ii8xMTA2NzU4MS8zMjQxMzA2MjUtYThhNGU0OWQtOGY5Ny00NmUwLTk4YTktMzZkYjNhM2UxNTY5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDE5VDIyMzMxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThlNWU3ZDMxYjU5NjhjYTUyM2Q3NTA1NzFhMjk0YmUxYWEzNDY0OGM2ODZiNDNlMzA4NzlhYmI4MGM3NzM1YjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.wNiHGYkb5xF8NqWxRYEyEuDqxt2SQKQXl9-XVFT57O8) I attempted to...