Benjamin Ross
Benjamin Ross
According to this: https://docs.gdax.com/?python#errors 'message' will be in the response body, so I just check for that key and raise a custom error. Something like this: ``` def _raise_for_error(self, response):...
I was just about to post that my sample method won't work. Not surprised that you ran into it too. I have no idea why the error checking was removed...
I like it, but I think we should also save the `response_code` in the exception as well. Otherwise looks good.
@duffar12 @acontry @alex0527 @js931 please have a look
@alimcmaster1 yes, I will make that change. I did not know those were defined in the PSL.
@danpaquin updated based on your concerns. Please let me know if there is anything else you want me to change. Cheers.
I definitely find it useful and am using it in my current setup. Let me know if we want to move forward with this and I can fix the rebase...
Updated things since this got a little out of date.
@anilgorgec you might try to leverage what I have implemented in this PR: https://github.com/moov-io/iso8583/pull/336 to see if it fixes your issue. Specifically the packer/unpacker implementation that handles even/odd length track...