bplaxco

Results 40 comments of bplaxco

@santiagolizardo cool, thanks! Out of the two (OIDC vs SAML) OIDC would be the preferred (plus I've found that one easy to implement by from scratch if not going the...

@santiagolizardo is there anything that needs to be done with this request (given the plan to add it to the roadmap), or is it alright if stalebot closes it out?

Cool cool, thanks for confirming ^_^

Changelog fragment added. Looking into the tests.

@tremble in the [zuul ouput](https://ansible.softwarefactory-project.io/zuul/build/e01e56bff92b48e4a1d154e7e02734c4/console) I get: ```json "error": { "code": "UnauthorizedOperation", "message": "You are not authorized to perform this operation. Encoded authorization failure message: SZOho26QkeN31KcOxBTUnC_sBSeRa3G9qqAmqJOLtkkAiUvLcOIlJVojSNLkyZa7MXEHWbTOAtc5aemsWR_tKiqEZtwr5OlwXk4PbtKTtj0NdpDaBeDs1q-Mpt7zDktDjJmk41tSPe-Rjjqe1ftFJhuZ76rQKHOXEeLol1QsaW2kA9x74EEf6gbr13kMUi2CyF3D-XTFMLkpZj-XShxzE9QbF1xvmnvwxIbmwuVk0PWFUX8dKbQbeB4K_jSCBLIV5Ag3Rio0Foc4h6uYfBmTz_vOR7J2ukyrRdgn5dwIc_78jFpa2DSqPa93EbGXeXjW6fTtzFvsExeRynD7-QBDY4iZEYGE2inBGZHZO7elmhh4Ie9G-xV6g2hBZVlWShrDzxGoJjanOiqTxl3530TxVRO-YO3kIzDbG55DouvtyOGdJyQntxyeIB2eR0gZhI5maCAcsD2YODtRyhwIDIXhGiBKmB4GmZ90ZgfQ0zHkLf4aLr5xxZcpeqf3juVUpMUMdOIWQ_VIdldVmPvx13e4FrsVACt4509Uh1vt5R7N-vX6YSh5g9CDrJ8" } ``` The module...

@tremble I went ahead and removed the tests to get the MR through since they were marked as optional, but since they seemed to be failing because of a permission...

Hey @tremble just wanted to see if you need anything else from me on this ^_^

Would the ability to define a scope be useful? (e.g. `file`, `commit`, `repo` etc) > Typically (I have no evidence), multi-component secrets are near one another. I might actually be...

> Another reason I prefer [[rules.requires]] is because it's consistent with the structure of allowlists. Way too out of scope for this conversation, but I started out with a response...

> In theory, this could be solved by increasing the lines of context, **but** the problem would then become secrets being detected in commits where nothing has changed. @rgmz I...