boxydog
boxydog
The functionality (paragraphs) seems reasonable. Using negative and positive SUMMARY_MAX_LENGTH feels confusing. I'd introduce a different config var. But, my opinion is not binding.
Less confusing would be SUMMARY_MAX_LENGTH (for words) and SUMMARY_MAX_PARAGRAPHS (for paragraphs). If both are set, could 1) apply both, or 2) pick a winner (e.g., SUMMARY_MAX_PARAGRAPHS), or 3) raise an...
Since this PR was created, someone merged a different inheritance scheme (THEME_TEMPLATE_OVERRIDES) in #2072, described in #2021. I don't understand THEME_TEMPLATE_OVERRIDES and THEMES well enough to know how they should...
In https://github.com/IHTSDO/snomed-database-loader/blob/master/PostgreSQL/README.md, it says to use load_release-postgresql.sh, so I was just doing whatever is documented. If I should use load-postgresql.sql directly with hand-editing, perhaps change the README? That is what...
I added "noqa: I001" and the import line stays in place. Now when I try to look at the pull request to see tests, github is giving me 404s half...
Is this PR ready?
> Given the quirks so far, I will have to go through the diff in detail to make sure nothing strange is going on. Sorry, I missed this message. Works...
Rebased to current main. Thoughts?
> I would be happy to merge this PR in its current form. Would you be amenable to that? Sounds good to me.
> If you are still willing to work on the TODO list Oh, I'd be willing to work on TODOs as well. I have no particular order in mind, tho....