botengyao

Results 50 comments of botengyao

Hi @itsjamie , can you (or anyone) help me review the code? Don't know why I cannot add a reviewer for this PR. I generated a `cbcs` encrypted fMP4 video...

Thanks @itsjamie ! Here is an sample [mp4](https://docs.google.com/uc?export=download&id=112xg44sZBeicWXsVm4ToVGUrEHeLjbYf) video. This video will be parsed and encrypted in `cbcs` pattern by Shaka-packager. Here is the command in Shaka-pakager (in docker): ```...

Want to check the reason of failing of `continuous-integration/travis-ci/pr`, I always get this kind of error even I am in `feature/v1.0.0` branch. It seems that the license server is down....

> If there's a healthcheck benchmark, can you also post the before/after results? Also, can you add some more context and/or a pointer to an issue that contains the context...

@envoyproxy/api-shepherds for anther look. Thank you!

Hi @robwalch, sorry, it is long time and I am not actively working on this. Feel free to reassign if someone wants to take over. Re-branching to the latest works...

Thanks @robwalch for the heads-up. Hi @TREER00T, feel free to take over my work and branch from the latest.

>Aside, @botengyao should the fix here be returning StopIterationAndWatermark rather than sendLocalReply? Seems if we've never sent data upstream, we should just delay until we have one. https://github.com/envoyproxy/envoy/commit/3c234770d2b1660fa6f3fdb1f9c3916933ec7b84#diff-e3584a650478334f7373c0df344c85d499b5123f5237ce2bbabaad5ee53b899eR910 I don't...

> > > Aside, @botengyao should the fix here be returning StopIterationAndWatermark rather than sendLocalReply? Seems if we've never sent data upstream, we should just delay until we have one....