Mica White
Mica White
I took a look at this, and found a problem which leads to this being way harder than expected. Here's what I have written: ```rust fn fmt(&self, f: &mut fmt::Formatter`...
According to the documentation for the `Drop` trait, "[Copy types] cannot have destructors", so they can't possibly be synonyms.
I'm also seeing a memory leak. Looking at dhat, I believe it could be due to command encoders not being removed from `executing_command_encoders`. Although, I am submitting the encoder. I've...
That `is_err` at the end means that the assertion will fail if the function was successful. The first statement was unsuccessful, probably because September only has 30 days. The second...
@djc I think we would need to modify the `TimeZone` interface in order to support getting earlier and later valid times for the timezone. Something like 1. Try to use...
@esheppa Interesting. I think we should try to do two methods though. One to find the next valid time, and one to find the previous valid time. I think to...
@kevincox For what it's worth, I think in that specific use case, you should probably create an error message saying that time doesn't exist on that day Now that I...
@kevincox Ah, that makes sense. I can imagine that causing problems too, but that's probably a fair compromise.
@dswij I like `unnecessary_box_return`. I think an 's' at the end is unnecessary.
@xFrednet Ah, ok. I'll make that change then