Bosco Ho
Bosco Ho
> @danielgronlund when do you plan to release the update? Agreed: would be nice to know if the fix is taking longer than expected. - This still appears to be...
@buresdv Is the animation logic in a private branch? Also animation works for `Installed Formulae` and `Installed Casks`, right?
Took a quick look at repro: - Seems like "Add" *does* animate, but it appears to animate the wrong tap (see video). - "Remove" tap indeed doesn't animate when triggered...
"Remove" tap animates with the same buggy behaviour as "Add" if triggered using button in Detail view (see end of video below): https://github.com/buresdv/Cork/assets/2549615/a7cae938-c62f-40b2-a754-a5e4d6ec7318
`func removeTap(name: String, availableTaps: AvailableTaps, appState: AppState, shouldApplyUninstallSpinnerToRelevantItemInSidebar: Bool = false)` - When `shouldApplyUninstallSpinnerToRelevantItemInSidebar = true`, animation fails. - When `shouldApplyUninstallSpinnerToRelevantItemInSidebar = false`, remove animates out the wrong tap.
Seems like remove formulae also doesn't animate at all: - Item being removed moves to a new index with spinner, then disappears without animation. https://github.com/buresdv/Cork/assets/2549615/94523b72-2920-4eb3-bda3-627071315222
**Update**: Added repo that reproduces behaviour (https://github.com/boscojwho/sidebar-list-add-remove-row-mac) Interesting, I made a test macOS project to see whether it's system behaviour/bug, and I was able to repro the behaviour here: https://gist.github.com/boscojwho/6bdf2df26750602262d23754ea90bcaa...
- I synced my fork with `main` branch yesterday (it's 4 commits behind today, but I don't see any changes related to this bug). - I reproduced this on Sonoma...
@buresdv So, if we use a `ScrollView + LazyVStack` setup in the sidebar, row insert/removal animations work properly (see video): - But the rows (NavigationLink) look different out-of-the-box. - So...
Yea, I can take a look and also switch out the current setup with this new one if you want.