bormanp comments

Results 6 comments of


                                            bormanp

feat: add uuid bytes

@it512 To get the bytes representation of a uuid you just have to say uuid[:] as you suggest, there is no reason for a function call. I believe the rationale...

fix to use MustParse("xxx") instead of Must(Parse("xxxx"))

Please address the failed check about commit messages. Other than that I see no problem with this code.

panic: uuid: Parse(): invalid UUID length: 0

As mentioned, this is the correct behavior of MustParse. Normally MustParse is used during initialization with fixed strings.

uuid.Parse function does not handle empty string

Closing this as an empty string does generate an error (it does not return nil). invalidLengthError{0} is a proper error and should not be confused with error(nil).

docs: upd links to rfc9562

The constant RFC4122 cannot be changed though a new constant could be defined to be equal with it. Probably `Standard = RFC4122` (or the other way around). Not sure it...

Moved NewV7FromReader to uuid_test since it shouldn't be used outside of testing

The "FromReader" functions were indeed added for testing purposes, but not for testing this package. This function makes it possible to have deterministic UUID's returned when validating a piece of...