bonnland

Results 45 comments of bonnland

I'm a new developer at the SciPy 2019 Sprints, and I'm interested in making a pull request for this issue as a learning step. @henrikca Would this be useful? Or...

So there are some units tests that assert the behavior for open_mfdataset() is identical to the behavior for concat(). This implies that if we change the default data_vars value from...

@dcherian . I believe you are correct in principle, but there is a logical problem that is expensive to evaluate. The difficult case is when two datasets have a variable...

@shoyer Your explanation makes sense, but there are unit tests that expect the default concat() behavior to be the same as default behavior for Pandas concat(), which tries to perform...

@shoyer I'm sorry I didn't look at your examples more closely at first. I see now that your first example of using data_vars='minimal' is already preserving one instance of the...

> Can you give a specific example of the behavior in question? Here is the most specific thing I can say: If I switch the default value for data_vars to...

I have tried to understand why the xarray developers decided to provide their own options for concatenation. I am not an experienced user of xarray, but I can't find any...

This seems related: https://github.com/ckan/ckanext-harvest/issues/151#issuecomment-487015469 If validation errors cause a session rollback, then is there a problem with adding a `Session.close()` right after it?

Sorry for the extra commits; I'm relatively new to PRs.

The harvester stops crashing if I rewind to this commit: https://github.com/ckan/ckanext-harvest/commit/819706ae5dce5c62b2283fd8405fd8b6fa804355 I have not explored exactly which commit between this one and the latest commit on the master branch introduced...