Bolaji Wahab
Bolaji Wahab
> I would wish the same for tsql where ine has CONVERT and CAST It could easily be extended to cover tsql.
@fmms Thanks for raising that. Indeed, tsql takes an optional styling for CONVERT which cannot be rewritten with CAST. In that case, the user can ignore the error with noqa...
> @bolajiwahab in my opinion the rule should only consider two-argument-converts. 3-argument-converts should neither raise a warning nor tried to be fixed. Okay. That is fair since we cannot rewrite...
@barrywhart and @alanmcruickshank if you have some spare time, can you review this PR? Thanks
> Great progress! A few suggestions. > > Do you plan to make any other changes? (I'm asking so I know whether to do a more thorough review now.) No...
> Great progress! A few suggestions. > > Do you plan to make any other changes? (I'm asking so I know whether to do a more thorough review now.) @barrywhart...
> @bolajiwahab: Are you planning to continue working on this PR? Hi @barrywhart yeah, I will be pushing my latest change this week.
> Thanks for letting me know. There's no pressure, I was just looking over the list of PRs yesterday and was curious. 🙏 Been quite hung up with a few...
> Awesome tested it on a small code base , it works perfectly 😃. Thanks Great to know that. And thanks for waiting so long for it. Cheers.
> A few lines of the rule are not covered by the tests. If it's reasonable to test those, that's good. If not, we add `# pragma: no cover`to get...