Justin Bogner

Results 6 comments of Justin Bogner

SM6.7 MSAA UAVs only include sample count info in the DXIL in annotateHandle instruction args

The metadata for UAVs doesn't have a field for sample count (it's an "SRV specific field" in https://github.com/microsoft/DirectXShaderCompiler/blob/main/docs/DXIL.rst#metadata-resource-records), so there isn't anywhere that could be updated. IIUC since SM6.6+ uses...

[HLSL] implement elementwise firstbithigh hlsl builtin

It is not correct to limit firstbithigh to 32 bit integers. There are a couple of reasons that might make one think that it is, but we do in fact...

[HLSL] implement elementwise firstbithigh hlsl builtin

> > Despite all of this, DXC does indeed support 16- and 64-bit overloads, as seen here: https://hlsl.godbolt.org/z/qbc17xz35 > > Note that the return type of the operation is not...

Switch from llvm::StringRef to char* for Toggle name to prevent static initializers

Upstream LLVM has `StringLiteral` which would be appropriate here, but it looks like that was added in late 2016 and isn't available in DXC. Using a `constexpr StringRef` should probably...

Create and use DXC DLL ext validation support class

The interface is a good idea, but there are a couple of things that still need some work here. Notably, Tex's concerns are about the usage of the `DxcDllSupport` APIs,...

Create and use DXC DLL ext validation support class

> To your last comment, I do think there is an argument to be made for having an Initialize() with no arguments. This way, we can at a singular location...