bobzilla
bobzilla
I did a patch for just the US given the comments here, seems to work ok: ``` - fips_code = geoname2fips.get(location['geoname_id']) + if country_iso_code == "US" and location['subdivision_1_iso_code'] != "":...
Some more info is in: https://github.com/sherpya/geolite2legacy/issues/27
fyi: ran into this on python 2.7, goes away on python3.
Should be fixed next release, due to https://github.com/ngrok/kubernetes-ingress-controller/pull/333
Ah, the [artifacthub](https://artifacthub.io/packages/helm/ngrok/kubernetes-ingress-controller) logo is fixed (and i was able to get us "verified" and "official" there, as well as removing the old version with the different project name). But...
Ah, gh-pages is missing the current `docs/assets/`, pr to fix: https://github.com/ngrok/kubernetes-ingress-controller/pull/348 Edit: merged, page fixed: https://ngrok.github.io/kubernetes-ingress-controller/
Looks like it eventually ran, seeing the linting lines: https://github.com/ngrok/kubernetes-ingress-controller/actions/runs/5060657393/jobs/9083840896?pr=231
For a more concrete style the builder pattern configuration can be used, here's an example of that which is more explicit: [ngrok-labeled.py](https://github.com/ngrok/ngrok-python/blob/main/examples/ngrok-labeled.py#L19)