Bob Myhill

Results 92 comments of Bob Myhill

I'd like both the 2D and 3D versions in the codebase. I think there's value to showing both, and it seems wasteful to remove @jdannberg's work. If the 3D version...

After discussing this PR with @gassmoeller and @jdannberg, we decided to instead remove the Reference Temperature parameter. This broke a bunch of tests, a cookbook and some benchmarks. I've now...

Spoke too soon. Lots of problems. Will try to fix tomorrow.

Firstly, sorry for the spam. Secondly, I figured out the problem. I had forgotten that with this EoS, alpha isn't actually constant, so it isn't possible to just shift the...

> in order to do that we need to check the benchmarks, cookbooks and tests that have changed and see how to restore their original results. I don't think we...

> I really like the idea of being able to set different field types. My guess would be that it would be a bit of work to make sure every...

I think it's a good idea. The only thing I wonder about is how you decide what to add at different OutputVerbosity levels, and how the user will know which...

You might find aspell useful for spell checking other big chunks of code - this is what I use once a year to catch all the new typos, and it's...

Hi @MFraters, a 2D implementation would only make sense if 2D deformation in a(n incompressible) 3D geometry model results in 2D CPO development (i.e. rotations are in-plane). Is this the...