Jan Bobisud comments

Results 25 comments of


                                            Jan Bobisud

Skip tags collection when route does not resolve successfully

👋, what is the status of this PR?

Remove attribute if property is `falsy` when rehydrating

😢 I'm not sure, how to properly handle failing tests in Edge and IE11, eq. `[NEW] Rehydration Tests: Dynamic multi-select` fails on expected `selected=""`, but got `selected="is-truthy"`, which should not...

Remove attribute if property is `falsy` when rehydrating

@glimmerjs/glimmer.js what do you think about this?

Remove attribute if property is `falsy` when rehydrating

@chadhietala, can you please take a look on the updated approach? I can not normalize values in `DefaultDynamicProperty`, because of other attributes (eq. `name="false"`), thus `BooleanDynamicAttribute` class with `isBooleanAttribute` helper...

Remove attribute if property is `falsy` when rehydrating

@chadhietala friendly ping about what do you think about proposed solution ☺️.

Remove attribute if property is `falsy` when rehydrating

@chadhietala, should be ready for review.

Remove attribute if property is `falsy` when rehydrating

Hi @tomdale and @wycats, do we have some update on this?

Unable to render a trigger component instead of the default one in new release of ember-power-select.

👋, @kaspiZonky and I faced with similar issue today - our component extending add-on's `trigger` was ignoring custom template. Since the add-on's components are co-located now, we were able to...

Add `fetch` API globals

CI is ✅ except tests related to `embroider`, which are already failing on `master` 🙈

Drop `FastBoot.require` for 3rd dependencies?

> Since inside an Ember application there is already a global variable named require (defined here), I don't see how you'd gain access to the Node-land require without having it...