Dave Thalmann

Results 11 comments of Dave Thalmann

See also https://passwordsgenerator.net/ for a nice online implementation. It has a "do NOT send across the Internet" Option, however an integration into DevToys would be nice.

Sounds OK to me, just keep that possibly open. The ifndef at the start is a good step too.

or checkout_cart_save_before works as well... I had to manually fix the event name to make it work in my shop. +1

Hey there, coming from reddit :) Some suggestions for an algorithm to solve this issue: - Check if the string contains LRM (0x200e) or RLM (0x200f) (and treat ARM 0x061c...

As for reference implementations: https://github.com/waiting-for-dev/string-direction Or http://en.wikipedia.org/wiki/Bi-directional_text on that topic (notice the table with the classifications). I'll work on it tonight :+1: However, probably need to refactor some methods into...

I tried my best to adapt the coding style. No tests broken (or lets say: some tests failed on my Ubuntu Dev Machine before I changed anything, seems like those...

Hey there, thank you for the ping. I was occupied this half year with doing my bachelor degree in CS. ;) We should define our definitive approach for this problem...

Hey Ivan, thanks for asking - my bachelor is done now, so I think, I will find some time to contribute. I will try to implement the algorithm according to...

Just a short update: I wrote a small script which parses the official bidi-classes from the unicode consortium (http://www.unicode.org/Public/UCD/latest/ucd/extracted/DerivedBidiClass.txt). It generates an optimized regex (not working atm, I miss something...

We need to distinguish between the different types of bidirectional characters. Especially as some characters "change" their directions depending on context (read: surrounding characters). It's quite complex at the start,...