Brad Moylan comments

Results 17 comments of


                                            Brad Moylan

Consistent name enforcement for param id

Fixed by #299

Discourage/deprecate set<double> and map<double, V>

+1 I am currently working on jumping through hoops to support these types in conjure-go (which does not natively support json-encoding of floating point map keys, and will straight-up fail...

Importing from the same package as a generated file

Here's how I'm thinking about it: there are two distinct places where the local package matters: - When we build the `imports (...)` block in `FileSpec.String()`, the local package should...

Rescale samples on reads too

Friendly ping @rcrowley @mihasya

Stop mill goroutine when logger is closed

Hey @natefinch mind taking a look at this?

Support Artifactory publishing without the maven product info in the path

@nmiyake @tabboud I've opened #346 with a proposed resolution: a `flat-dir` boolean option which omits the maven directories. Let me know what you think!

improvement: Refactor internal middleware to shorten overall stacktrace

I will likely end up breaking this into multiple PRs so the diffs are more traceable, but this is a start

improvement: Add health check source registry

___ *[status/registry/source.go, line 39 at r1](https://reviewable.io/reviews/palantir/witchcraft-go-server/177#-MZYBfP28OSY9A0yYarF:-MZYBfP28OSY9A0yYarG:b-aoshr) ([raw file](https://github.com/palantir/witchcraft-go-server/blob/4dddc52c7db795dbac31daa97bdf06be19701c4a/status/registry/source.go#L39)):* > ```Go > > type timedHealthCheckSource struct { > timestamp time.Time > ``` Hey @splucs sorry this PR has languished so long....

Time-based log rotation

I've pushed https://github.com/bmoylan/lumberjack/pull/1 which proposes a change to lumberjack for rotating after a max time

Time-based log rotation

Just found https://github.com/natefinch/lumberjack/pull/76 which sounds like he probably would not accept the contribution