Brian Moeskau

Results 9 comments of Brian Moeskau

I ran into this trying to install nvm from an automated Ansible playbook, so "hitting q" is not an acceptable workaround. Also, manually adding the config block to `.zshrc` doesn't...

I dug into this today and here is what I found. The issue was introduced in the January 13 changes to `install.sh`, specifically around [lines 131-157 in the diff](https://github.com/nvm-sh/nvm/commit/502089ae308c3a771e09d233f8221ea17a0647dd#diff-043df5bdbf6639d7a77e1d44c5226fd7371e5259a1e4df3a0dd5d64c30dca44fL131-R157). It...

Seems like there have been no takers on this yet. It looks like @nmarghetti was the committer for the [diff](https://github.com/nvm-sh/nvm/commit/502089ae308c3a771e09d233f8221ea17a0647dd#diff-043df5bdbf6639d7a77e1d44c5226fd7371e5259a1e4df3a0dd5d64c30dca44fL131-R157) I outlined above. Any chance they are available to weigh...

Once you clean up these changes I'll merge the PR.

I've had a chance to look at this a bit -- thanks for the translations! Regarding the date methods, I would be more inclined to have the locale file override...

@ziadloo Looking further, I assume that you mean the issue is with this code inside the Jalali calendar code, which requires the original Date methods to work as expected: ```...

Thanks a lot for the contribution -- I've planned on converting to SASS for version 2.0 of Extensible, so I'm not going to merge this just yet, but I'll take...

Thanks for the PR. I can't merge it at the moment, since even though it only impacts the styles, it could be considered a "breaking" change if someone has customized...

I have an internal road map that is subject to change, but I haven't yet announced anything publicly.