Brian Hatfield

Results 25 comments of Brian Hatfield

I just spent some time trying out different commit SHAs, and it appears that this commit is what introduced this breakage: https://github.com/asaskevich/govalidator/commit/2abf7b9d5da33ab5e25960c301ca26f779a88db9 The switch from `isEmptyValue` to `isFieldSet` coupled with...

Bump? Based upon the responses here, it seems like the [breaking commit author's understanding is incomplete](https://github.com/asaskevich/govalidator/pull/329) and perhaps 329 should be reverted? In particular, assuming that everyone can use pointers...

It appears this issue may have been resolved: https://github.com/asaskevich/govalidator/commit/63eac4636d06ec91ef7f8290e2e021912e610051

For a little bit of extra context, this seems to require a pretty specific set of circumstances for us. When the tunnel drops, sometimes it's detected and a reconnect happens,...

Just wanted to ping this also isn't working for me - everything seems to go fine with the patch, but the display preferences for the 27ud88 only show 30hz (greyed...

Thank you for your notes, this is very helpful! In other discussions of Bolt, I had observed that the authors claim that sequential inserts see a large performance increase. Are...

@nathankot I'm a bit torn here. This definitely would solve for the "principle of least surprise" dimension, but this breaks a use-case for us, which is being able to externalize...

> Just realized our use-case is similar to yours where we want to pass in a custom string for development, I updated this PR so that Environment.url becomes publicized as...

After reading this issue https://github.com/census-ecosystem/opencensus-go-exporter-stackdriver/issues/100 which indicated that the examples don't work, and suggested that folks try [this documentation](https://opencensus.io/quickstart/go/tracing/), I was able to add the following line: `trace.ApplyConfig(trace.Config{DefaultSampler: trace.AlwaysSample()})` and...

PS: I'm happy to put up a PR to execute the promise on the event loop, but I wasn't sure what the intended behavior here was, hence this discussion issue...