Bryan Matsuo

Ineffective thread locking.

4

The usage of `runtime.LockOSThread()` and `runtime.UnlockOSThread()` seems incorrect to me. Child transactions will unlock their parents on `Commit` or `Abort`. Dealing with this is fairly trivial except maybe in the...

fix thread locking for nested transaction

3

Nested transaction need to know that they are nested so they don't call `runtime.UnlockOSThread` while their parent is pending. There's a pretty big warning about thread safety on the godoc...

Reset method / sync.Pool support

13

@mreiferson what is your opinion about adding Reset methods to the types in this package? Other buffered IO types like those in "bufio" and "compress/gzip" supply such a method. I...

Potential benchmark data source: Silesia corpus

2

I was reading about [lz4](https://code.google.com/p/lz4/) and noticed they use a [specific dataset](http://sun.aei.polsl.pl/~sdeor/index.php?page=silesia) for the published benchmarks. It looks like a good bunch of data files to benchmark with. But it's...

Confusion with the `update` method of HandBrake::CLI

2

This is suggestion based entirely on opinion. It is also probably fairly low priority due to the fact that the method in question is not critical to the functionality of...

Problem with CLI options using optional arguments.

3

HandBrakeCLI options which make use of optional arguments need to have their argument given using the equals sign in the form `--option=value`. The gem doesn't do this. And as a...

lmdbpool: Do not use sync.Pool

1

A proper free list of Txns should probably not use sync.Pool for its underlying storage. It can work for some applications, which I have tried to clearly explain in the...

Closes #11 I am opening this now because it is **close** to done. But it is probably not done right now. It is a rather large change though. So I...

lmdb: Support integer flags (MDB_INTEGERKEY/MDB_INTEGERDUP)

16

I would like to attempt support for `MDB_INTEGERKEY` and `MDB_INTEGERDUP` (See [`mdb_dbi_open`](http://symas.com/mdb/doc/group__internal.html#gac08cad5b096925642ca359a6d6f0562a)). Any user attempting benefit from them would be in tricky "unsafe" territory without more direct support. But the...

The lmdb package has to adjust empty inputs to allow CGO calls to succeed in the general case. But this adjustment causes Cursor.PutMulti to panic when it tries to validate...