bmanga

Results 20 comments of bmanga

I'd like to be part of the EAP

+1 for moving the cmake files into ComputeCpp from me. The installation without these files is not very practical, and it seems from the commit history that those files are...

If I add the `--output-format=ll` to the test file then the error is not triggered as I think it happens at a later stage. Keeping the test file as I...

Mh I've tried that and it seems like clspv crashes before being able to dump anything to the file...

Ah ok I misunderstood your previous comment. I thought you wanted the test to fail through FileCheck and I assumed that flag would output something I could act upon without...

@fmassa May I suggest to use an inline variable or a function to register the operators instead? I can give that a try first, so we can avoid hacks in...

@fmassa Inline variables should work just like the current approach. Officially they are C++17, but we can get essentially identical functionality using `__attribute__((weak))`. I personally don't mind a RegisterOps function....

@ezyang true, late night thoughts should be left for the morning 😅 I think it is a bit unreasonable to expect the operators to be registered just by linking the...

@fmassa because if we really want this behavior * it should be done for windows, mac and linux * We want to limit it to torchvision only, so we need...