Brendan McLoughlin

Results 24 comments of Brendan McLoughlin

@wecc Seems people need a public way to create snapsnots for custom adapters ([example](https://github.com/kurko/ember-json-api/pull/64/files)). I'd be in favor of making the constructor public but I know there were some reservations...

This issue was discussed in the last Ember Data meeting and it was decided that adapters will get passed an instance of a snapshot instead of a record. For unit...

I believe the main concern was attempting to reduce the surface area of the public api. The hope is that https://github.com/emberjs/data/pull/2883 will fix most of the reasons why a public...

@pangratz I think I remember you fixing this issue. Is that correct?

I have opened a pr so Ember Data will warn in the future when `JSONAPISerializer` and `EmbeddedRecordsMixin` are combined. https://github.com/emberjs/data/pull/4259 I don't think `JSONAPISerializer` and `EmbeddedRecordsMixin` will work together out...

This sounds like a bug. @igorT can you confirm that `coalesceFindRequests` should coalesce async relationship requests?

Thanks for reporting this. I'm not currently using Sails 0.10 on any projects but I will try to set up a demo project today and debug this.

I updated the adapter to use `io.socket` instead of `socket`. I was also running into a problem in `sails.io.js` when Ember is extending the array prototype. As for pluralising the...

Hmm @guernica0131 has a point about reducing confusion. If we use pluralizes routes by default in the adapter then we require everyone who wants to use pluralizes routes to set...

@nmec @guernica0131 I have opened a pull request https://github.com/bmac/ember-data-sails-adapter/pull/25 where I refactored both `SailsRESTAdapter` and `SailsSocketAdapter` to extend from Ember Data's built in `RESTAdapter`. This way it will be easier...