Michelangelo Mori issues

Results 32 issues of


                                            Michelangelo Mori

Make github webhook easier to extend with new events for auto registration.

# Summary The idea is to make it easier to extend github webhook with events that are tied to more than one repository, namely "installation" and "installation_repositories", which are necessary...

Refactor GitHub webhook handler to have a case for each event of interest

Currently, the GitHub webhook handler treats different event types uniformly and the "dispatch logic" for each event is spread over multiple routines. This makes it harder to extend the logic...

tests using createRandomOrganization occasionally create invalid org names

### Describe the issue Tests using `createRandomOrganization` occasionally run into a key violation due to [this line](https://github.com/stacklok/minder/blob/main/internal/db/organizations_test.go#L37) creating identical names when lower-cased. ``` ❌ TestCreateProfileStatusMultiRuleTransitions/0x87 (30ms) profiles_test.go:2802: Error Trace: /Users/michelangelo/stacklok/minder/internal/db/organizations_test.go:42...

bug

Feature flags not working when evaluated outside the context of a request

### Describe the issue Feature flags evaluated outside the context of a request don't populate `EvaluationContext` correctly. An example of where this bug happens is [here](https://github.com/stacklok/minder/blob/main/internal/engine/eval_status.go#L204), which is the code...

bug

List `Model` `Index` returns index offset based on filtered list, but `SetItem` expects global offset in items list.

**Describe the bug** The index value retrieved by using `Index` returns an offset that implicitly takes into account whether filtering is active, so an hypothetical value o `0` is actually...