Brian Rodgers

Results 10 comments of Brian Rodgers

OK, I just pushed an option that checks if you're running inside docker (docker containers get a /.dockerinit file mounted inside them). If inside docker, it'll leave the hostname out,...

So you've run into an issue we've recently identified ourselves when we tried to start doing more nested templates rather than one big monolith VPC template. I've got an issue...

I should add that what I describe is the ideal fix, that is, one that doesn't completely remove the type safety. We could also consider changing to `Token[String]` for now...

We don't use it internally anymore, but if you want to do a PR, I can merge it and try to publish a new version.

@milenkovicm Do you think you could submit a PR with your changes to make it 2.12 compatible? If it strips 2.11 compatibility or contains any breaking changes we might need...

I'm all for doing that, but don't have much time on my side to work on it. Would welcome a PR for it.

One way to solve this would be to do what `Fn::FindInMap` does and accept a type parameter. Rather than change the existing `GetAtt`, we could add a new `Fn::GetAttFromStack` that...

We decided to go with Bintray/JCenter instead of pushing to Maven Central awhile ago. I wasn't that directly involved in that decision but unfortunately those who were have all left....

@chrisshafer I'm finally getting around to catching up on PRs here. Is this still something we'd like to see merged? I see @tj-corrigan had a couple comments.

Thanks @tylersouthwick for the change to take `Map[String, Token[String]]`. I've merged that in. I'm going to keep this issue open for now though, as I'm still thinking I may want...