bjangelo comments

Results 18 comments of


                                            bjangelo

Leaves terminal in raw mode when calling shell.Close() asynchronously

I ran into this issue recently and was able to work around it with the following patch to readline. ``` diff --git a/std.go b/std.go index 61d44b7..70f477c 100644 --- a/std.go +++...

Leaves terminal in raw mode when calling shell.Close() asynchronously

> There is still no synchronization in ishell to wait for the goroutines to exit, but just delaying before program exit with this patch does cause raw mode to exit....

encoding/asn1: bool values not unmarshaled into interface type

Perhaps the `parseField` function is just missing a case statement for `TagBoolean` when dealing with `any` type? ``` diff --git a/src/encoding/asn1/asn1.go b/src/encoding/asn1/asn1.go index 781ab87691..72d3f84f1c 100644 --- a/src/encoding/asn1/asn1.go +++ b/src/encoding/asn1/asn1.go @@...

ext4 journal descriptor block parsing error.

Ran into this exact issue parsing the journal of an EXT4 file-system with JBD2_FEATURE_INCOMPAT_CSUM_V3 set. Applying the ext2fs_journ_dentry structure patch in the issue description resolved the issue, although I recognize...

ext4 journal descriptor block parsing error.

Looks like someone originally opened a pull request to just modify the structure. - https://github.com/sleuthkit/sleuthkit/pull/1477 I don't think this is sufficient as the size is dependent on feature flags. Here...

ext4 journal descriptor block parsing error.

I think ideally I would need file-system images with the following combinations of journal superblock flags (https://www.kernel.org/doc/html/latest/filesystems/ext4/journal.html#super-block): **1** - JBD2_FEATURE_INCOMPAT_CSUM_V3 **disabled** - JBD2_FEATURE_INCOMPAT_CSUM_V2 **disabled** - JBD2_FEATURE_COMPAT_CHECKSUM **disabled** **2** - JBD2_FEATURE_INCOMPAT_CSUM_V3...