Bipin Prasad
Bipin Prasad
close/reopen for rebuild
I think a good reason to catching this early (i.e. at submission time) is that the cycle time for error detection is longer. Case in point is JVM options changes...
(1) No new tests have been added. Following code that uses get_msg() was changed as part of this change - java: https://github.com/apache/storm/pull/3337/commits/685c81743bc4feb7a11fcbe94d1cd79e0228fd65 and - clojure (test): https://github.com/apache/storm/pull/3337/commits/5ea0ac6558244a49bf935c00c7d6d1930dbd7525 (2) No new...
Thanks for the explanation. Only way to check item (4) is to do a "binary" check on the topology jar to test for incompatible use (i.e. use of these specific...
- I did comprehensive search: grep get_msg/set_msg on **/*.py, **/*.java, **/*.clj. All calls are accounted for this change request. - So this leaves only the user topology jars, which may...
> > * I did comprehensive search: grep get_msg/set_msg on **/_.py, **/_.java, **/*.clj. All calls are accounted for this change request. > > * So this leaves only the user...
Changes look fine. Since it has been a while, can you rebase your commit. Thanks