Billy Vong

Results 129 comments of Billy Vong

I think there is (or was) a script to generate the TS interfaces. I haven't had much time to work on this, but I wanted to have some automation to...

I would be in favor of supporting Volta!

* yarn should not be a requirement, I will get that fixed asap. * I will add a boilerplate for an example plugin so people can clone and get started...

@fkling Is it not possible for the parser to share the same set of plugins as the transformer?

I get this on Safari 10.0.3: ![screen shot 2017-02-20 at 8 39 59 pm](https://cloud.githubusercontent.com/assets/79684/23151062/f1d2c4ee-f7ac-11e6-8617-1db43fc15735.png)

@elrumordelaluz Have you tried the above with `page.setContent` instead of `page.goto`?

Yeah bundle size is the main concern. Additionally, we would like to put loading the library behind a feature flag, which happens much later down the line and we would...

It looks like this is more appropriate for the [toolkit repo](https://github.com/actions/toolkit/issues/872). I will keep this issue open as there may need to be changes in this repo to pass options...

The callback handler for the element defined at `nextOnTargetClick` is [targetClickNextFn](https://github.com/linkedin/hopscotch/blob/master/src/js/hopscotch.js#L1389). If you trace through the handler, `nextStep` is called with no parameters, e.g. `doCallbacks` in `changeStep` is false, and...