Jon Janzen

Results 81 comments of Jon Janzen

@PranayAgarwal, sorry this took me ~8 months to respond to your changes, I got sidetracked on other side projects :/ Please take another look when you get a chance

After reading the code a bit, it seems this is a known problem: https://github.com/facebook/pyre-check/blob/main/source/analysis/test/integration/typeVariableTest.ml#L3759

After discussing with @pradeep90 it seems the only way to support this is to synthesize a pyre-ignore on the synthesized `TypeVar`. This can be added with `TypecheckFlags`

@marcesengel are you still working on this? Or would you mind if someone else took this over?

I've got the same problem, I use the `@classonlymethod` annotation to make sure that callers have to use the full class name instead of `self`. It helps reason about what...

I've opened a new PR here to pick up where this left off: https://github.com/django/django/pull/16547

@hicqu, we have no record of you signing the CLA. Please fill out the form again

@carltongibson: I've added the missing test coverage (such as I could, see inline comment) and fixed the thing you noted. I'm not sure this should be merged before https://github.com/django/channels/pull/2090 is...

Maybe I should slightly tweak this PR then: introduce an async “clean_up_db_connections” decorator and then document *that*

Makes sense. I’ll noodle on this for a bit and see what I can figure out (I only really have time to work on Django in my spare time, and...