Dan Rasmussen comments

Results 7 comments of


                                            Dan Rasmussen

Support schema references for Avro, Protocol Buffer, and JSON schema

Hi @Nevon Could you please provide me with an example of where typehooks are used to implement logical types? Then I will add it to the tests and fix it?

Support schema references for Avro, Protocol Buffer, and JSON schema

Hi @Nevon I change the code, so schema references always are parsed for Avro even if a user`typeHook` is defined. The `typeHook` will be called for each `avro.Type.forSchema` call in...

Support schema references for Avro, Protocol Buffer, and JSON schema

Hi @Nevon when do you have time to have a look at the pull request? The update should handle user-provided `typeHook` as you requested.

Support schema references for Avro, Protocol Buffer, and JSON schema

Hi @Nevon Thanks for your review. I have fixed your review comments and added a test for `LegacyOptions`, please have a look.

Support schema references for Avro, Protocol Buffer, and JSON schema

The `ts-ignore` is needed because the ajv.d.ts does not define `addSchema`. Ajv extends Core and Core implements `addSchema`, that is why it works. Plese let me know if I can...

Support schema references for Avro, Protocol Buffer, and JSON schema

Thanks a lot, Nevon - it has been a pleasure.

Add option to merge into an array using an index

do you still need this?